Skip to content

fix(ramps-controller): drop unused headless minimumVersion helper - #9668

Merged
saustrie-consensys merged 2 commits into
mainfrom
fix/ramps-drop-headless-minimum-version
Jul 27, 2026
Merged

fix(ramps-controller): drop unused headless minimumVersion helper#9668
saustrie-consensys merged 2 commits into
mainfrom
fix/ramps-drop-headless-minimum-version

Conversation

@saustrie-consensys

@saustrie-consensys saustrie-consensys commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Explanation

Removes getHeadlessAllProvidersMinimumVersion from @metamask/ramps-controller. App-version gating for moneyHeadlessAllProviders is owned by the LaunchDarkly versions wrapper (processed by RemoteFeatureFlagController), not a payload minimumVersion field. featureVersion fail-closed enablement and providerIds allowlisting are unchanged.

Supersedes #9658 (fork PR with CI issues). Changes are identical; this PR is from the org repo so the merge-queue CI can resolve the branch correctly.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Breaking public API removal; consumers importing the helper must update, though runtime headless enablement and allowlisting behavior in this package is unchanged.

Overview
Breaking: Drops the exported getHeadlessAllProvidersMinimumVersion helper from @metamask/ramps-controller (implementation, package export, and unit tests). The unreleased changelog records that app-version gating for moneyHeadlessAllProviders is expected to come from the LaunchDarkly versions wrapper handled by RemoteFeatureFlagController, not from a minimumVersion field on the flag object payload.

isHeadlessAllProvidersEnabled, getHeadlessProviderAllowlist, and featureVersion fail-closed behavior are unchanged.

Reviewed by Cursor Bugbot for commit aa04b15. Bugbot is set up for automated code reviews on this repo. Configure here.

@saustrie-consensys
saustrie-consensys added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit 8f65f2c Jul 27, 2026
54 checks passed
@saustrie-consensys
saustrie-consensys deleted the fix/ramps-drop-headless-minimum-version branch July 27, 2026 20:20
@saustrie-consensys saustrie-consensys mentioned this pull request Jul 27, 2026
4 tasks
pull Bot pushed a commit to dmrazzy/core that referenced this pull request Jul 27, 2026
## Explanation

This release bumps:
- `@metamask/ramps-controller` 17.2.0 to **18.0.0** (major) - removes
`getHeadlessAllProvidersMinimumVersion`, which was made redundant when
version gating was moved to the LaunchDarkly `versions` wrapper owned by
`RemoteFeatureFlagController`. See MetaMask#9668 for context.
- `@metamask/transaction-pay-controller` 26.0.0 to **26.0.1** (patch) -
updates its `ramps-controller` dep to `^18.0.0` and picks up two
previously unreleased dep bumps (ramps-controller and
assets-controller).

## References

* Related to MetaMask#9668

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [x] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> The ramps-controller major drops a public helper; any client still
calling `getHeadlessAllProvidersMinimumVersion` must migrate to
RemoteFeatureFlagController version gating before upgrading.
> 
> **Overview**
> **Release 1150.0.0** publishes version bumps for
`@metamask/ramps-controller` and `@metamask/transaction-pay-controller`,
plus matching root and lockfile updates.
> 
> `@metamask/ramps-controller` moves to **18.0.0** with a **breaking**
removal of `getHeadlessAllProvidersMinimumVersion`; minimum app version
for `moneyHeadlessAllProviders` is expected to come from LaunchDarkly’s
`versions` wrapper via `RemoteFeatureFlagController` instead of a flag
payload field. `@metamask/transaction-pay-controller` is patched to
**26.0.1**, raising its `ramps-controller` dependency to `^18.0.0` and
recording dependency bumps (including `assets-controller`).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
2296213. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants