feat: resolve swap quote metadata by migration phase - #9744
Open
micaelae wants to merge 84 commits into
Open
Conversation
This reverts commit aa5c5d2.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
micaelae
force-pushed
the
swaps4547-use-v2-migration
branch
from
August 7, 2026 01:11
363f891 to
8257447
Compare
micaelae
enabled auto-merge
August 7, 2026 01:15
micaelae
force-pushed
the
swaps4547-use-v2-migration
branch
from
August 7, 2026 01:33
cb46f5f to
3885f72
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3885f72. Configure here.
| priceImpact: toTokenAmountValues(priceData?.priceImpact), | ||
| // Use priceImpact as cost | ||
| cost: toTokenAmountValues(priceData?.priceImpact), | ||
| }), |
There was a problem hiding this comment.
Wrong cost from price impact
Medium Severity
In the V2 metadata path, cost is copied from priceImpact instead of being derived from sentAmount and adjustedReturn. Under V2WithV1Fallback, that value is merged over the correct legacy cost, so submit/history metrics can store an understated cost when network fees differ from price impact.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3885f72. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Draft client PRs
References
Checklist
Note
High Risk
Breaking selector and
mergeQuoteMetadataAPIs plus phase-dependent fee/amount shaping can change what users see and what metrics receive if clients pass the wrong phase or lag on adoption.Overview
Introduces a phased migration from client-calculated legacy quote metadata to V2 nested metadata from the bridge API, controlled by a new
migrationPhaseparameter.bridge-controller: Clients must pass optional
migrationPhaseon quote selectors (defaults to Phase 1). ExportedQuoteMetadataMigrationPhasedefinesV1Data(legacycalcQuoteMetadataonly),V2WithV1Fallback(prefer API V2 + fiat derived fromusd, fall back to legacy), andV2Only(no legacy top-level fields).mergeQuoteMetadatais breaking: V1 quote support removed; signature now includesmigrationPhaseand optional V2currencyValuesfrom newtoCurrencyValues.toQuoteMetadataV1is phase-aware so submission/history can rebuild legacy-shaped fields from V2 when needed.bridge-status-controller:
submitTx,submitIntent, andsubmitBatchSellacceptmigrationPhaseand use it when coercing V2 quotes to V1 for metrics/history (spread merge instead ofmergeQuoteMetadatain tests).Consumers (extension/mobile draft PRs) must adopt the new selector param and align phase with their rollout.
Reviewed by Cursor Bugbot for commit 3885f72. Bugbot is set up for automated code reviews on this repo. Configure here.