fix: preserve staked balances on Accounts API updates - #9753
Open
salimtb wants to merge 3 commits into
Open
Conversation
salimtb
added a commit
that referenced
this pull request
Aug 3, 2026
…eased The entry was mistakenly placed in the released 11.3.0 section; move it under Unreleased and add the PR link (#9753). Co-authored-by: Cursor <cursoragent@cursor.com>
Exclude staking vault asset IDs from Accounts API v5/v6 balance processing and keep prior staked amounts when replaceCoveredChainBalances would drop them, so network switches no longer reset pooled staking to missing/0. Co-authored-by: Cursor <cursoragent@cursor.com>
…eased The entry was mistakenly placed in the released 11.3.0 section; move it under Unreleased and add the PR link (#9753). Co-authored-by: Cursor <cursoragent@cursor.com>
salimtb
force-pushed
the
fix/preserve-staked-balance-accounts-api
branch
from
August 3, 2026 08:14
866dfb4 to
6a9595c
Compare
…ource test Co-authored-by: Cursor <cursoragent@cursor.com>
bergarces
approved these changes
Aug 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude staking vault asset IDs from Accounts API v5/v6 balance processing and keep prior staked amounts when replaceCoveredChainBalances would drop them, so network switches no longer reset pooled staking to missing/0.
UI PR: MetaMask/metamask-mobile#34178
Explanation
References
Checklist
Note
Medium Risk
Changes balance merge behavior for staking vault asset IDs during Accounts API updates; scope is narrow but incorrect logic could still show wrong staked ETH balances.
Overview
Fixes pooled staking balances disappearing when Accounts API refreshes balances on network switch or other chain-slice updates (
replaceCoveredChainBalances).AccountsApiDataSource now skips staking vault contract asset IDs when mapping v5/v6 balance rows, so the API cannot treat the vault share token as a normal ERC-20 and overwrite or zero out amounts owned by StakedBalanceDataSource.
AssetsController merge logic for covered-chain replacement now carries forward any prior staking-contract balances that the incoming slice omits, instead of clearing them.
Tests cover v5/v6 API filtering and preservation during
AccountsApiDataSourcemerge replaces; changelog documents the fix.Reviewed by Cursor Bugbot for commit 3696566. Bugbot is set up for automated code reviews on this repo. Configure here.