Skip to content

fix: include quote slippage value in MixPanel event properties #9786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
micaelae wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: include quote slippage value in MixPanel event properties #9786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e539c49
fix: include quote slippage value in MixPanel event properties
micaelae Aug 4, 2026
1c15ee4
chore: changelog
micaelae Aug 4, 2026
379bdd3
Merge branch 'main' into swaps4446-fix-post-submit-slippage
micaelae Aug 4, 2026
cba782d
changelog
micaelae Aug 4, 2026
75280ce
Merge branch 'main' into swaps4446-fix-post-submit-slippage
micaelae Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/bridge-status-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bump `@metamask/accounts-controller` from `^39.0.6` to `^39.0.7` ([#9791](https://github.com/MetaMask/core/pull/9791))
- Bump `@metamask/keyring-controller` from `^27.1.0` to `^27.1.1` ([#9791](https://github.com/MetaMask/core/pull/9791))

### Fixed

- Include quote's `slippage` value in post-submission MixPanel event properties ([#9786](https://github.com/MetaMask/core/pull/9786))

## [75.0.0]

### Changed
Expand Down
3 changes: 2 additions & 1 deletion packages/bridge-status-controller/src/__snapshots__/bridge-status-controller.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4819,6 +4819,7 @@ exports[`BridgeStatusController submitTx: EVM swap should use quote txFee when g
"gasIncluded7702": false,
"minDestTokenAmount": "941000000000000",
"requestId": "197c402f-cb96-4096-9f8c-54aed84ca776",
"slippage": 0.01,
"srcAsset": {
"address": "0x0000000000000000000000000000000000000000",
"assetId": "eip155:42161/slip44:60",
Expand Down Expand Up @@ -4873,7 +4874,7 @@ exports[`BridgeStatusController submitTx: EVM swap should use quote txFee when g
],
},
"quoteId": undefined,
"slippagePercentage": 0,
"slippagePercentage": 0.01,
"startTime": 1234567890,
"status": {
"srcChain": {
Expand Down
1 change: 1 addition & 0 deletions packages/bridge-status-controller/src/bridge-status-controller.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4396,6 +4396,7 @@ describe('BridgeStatusController', () => {
...quoteWithoutApproval,
quote: {
...quoteWithoutApproval.quote,
slippage: 0.01,
gasIncluded: true,
gasIncluded7702: false,
feeData: {
Expand Down
2 changes: 1 addition & 1 deletion packages/bridge-status-controller/src/bridge-status-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,7 +1315,7 @@ export class BridgeStatusController extends StaticIntervalPollingController<Brid
quoteResponse: payload.quoteResponse,
accountAddress: params.selectedAccount.address,
isStxEnabled: params.isStxEnabled,
slippagePercentage: 0, // TODO include slippage provided by quote if using dynamic slippage, or slippage from quote request
slippagePercentage: payload.quoteResponse.quote.slippage ?? 0,
});
this.#reportSubmittedForNonEvmTx(
payload.historyKey,
Expand Down