tests: add functional tests#189
Merged
cryptodev-2s merged 1 commit intofeat/add-dependency-bump-checkerfrom Dec 3, 2025
Merged
tests: add functional tests#189cryptodev-2s merged 1 commit intofeat/add-dependency-bump-checkerfrom
cryptodev-2s merged 1 commit intofeat/add-dependency-bump-checkerfrom
Conversation
a40520c
into
feat/add-dependency-bump-checker
13 checks passed
| await environment.updateJsonFileWithinPackage('a', 'package.json', { | ||
| dependencies: { | ||
| '@scope/b': '1.0.0', | ||
| }, |
There was a problem hiding this comment.
Bug: Test setup uses wrong initial dependency version
The test "updates existing changelog entry when dependency is bumped again" has inconsistent setup. The initial package.json sets @scope/b to 1.0.0, but the changelog already documents a bump "from 1.0.0 to 2.0.0". The comment at line 1853 confirms the intent is to test bumping "from 2.0.0 to 3.0.0". The initial dependency version should be '2.0.0' to match the changelog state and test the intended "bump again" scenario. As written, the git diff will show a change from 1.0.0 to 3.0.0, not 2.0.0 to 3.0.0.
cryptodev-2s
added a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Add comprehensive functional tests for
check-depsand arunCheckDepshelper to execute it within the monorepo environment.check-depssuite insrc/functional.test.tscovering:--fixauto-inserting/updating Unreleased changelog entries (including BREAKING peerDeps, multiple bumps, re-bumps merging PRs, renamed packages).runCheckDepstotests/functional/helpers/monorepo-environment.tswith options--from,--to,--fix,--prto invoke the tool.Written by Cursor Bugbot for commit 67065be. This will update automatically on new commits. Configure here.