This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Revert "feat: Add useCache optional param to getLatestBlock() (#340)" - #350
Closed
jiexi wants to merge 2 commits into
Closed
Revert "feat: Add useCache optional param to getLatestBlock() (#340)"#350jiexi wants to merge 2 commits into
useCache optional param to getLatestBlock() (#340)"#350jiexi wants to merge 2 commits into
Conversation
…)" This reverts commit 1d1406b.
Member
|
Instead of removing this flag, we're going to document the bug with this flag and fix it in a later PR. For now we've removed any usages of this flag instead as a workaround (see MetaMask/eth-json-rpc-middleware#421) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1d1406b.
Note
Removes the
useCacheparameter fromgetLatestBlock()and updates implementation/tests accordingly; changelog updated.PollingBlockTracker.getLatestBlock()no longer accepts the optional{ useCache }parameter; callers usegetLatestBlock()with no args.getLatestBlock()to always return cached value if present or fetch/wait depending on running state; removes delayed pending-promise reset used for rate limiting when not running.{ useCache: false }scenarios and adjusts related expectations.CHANGELOG.mdunder[Unreleased]to note the removal and clarify freshness behavior.Written by Cursor Bugbot for commit fd461a4. This will update automatically on new commits. Configure here.