This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Conversation
adonesky1
force-pushed
the
yarn-v3
branch
2 times, most recently
from
39bf28d to
14d33f3
Compare
adonesky1
force-pushed
the
yarn-v3
branch
2 times, most recently
from
f89aa51 to
9b57166
Compare
mcmire
reviewed
Nov 17, 2022
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Nice job on this, just had a few suggestions.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
mcmire
reviewed
Nov 17, 2022
| key: yarn-cache-${{ runner.os }}-${{ steps.yarn-version.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }} | ||
| - run: yarn --frozen-lockfile | ||
| - run: yarn allow-scripts | ||
| - run: yarn --immutable --immutable-cache |
There was a problem hiding this comment.
Hmm... maybe we don't want --immutable-cache after all, since it seems to fail if the cache folder doesn't exist (see CI). @Gudahtt What do you think?
Member
There was a problem hiding this comment.
The --immutable-cache flag was meant to be used in the post-prepare jobs, where it was guaranteed the cache would be populated. Agreed that we shouldn't use it here.
There was a problem hiding this comment.
Agh, my bad, that's right. Sorry @adonesky1 we don't want this after all, so this should just be yarn --immutable 😅
Gudahtt
reviewed
Nov 18, 2022
Gudahtt
reviewed
Nov 18, 2022
Gudahtt
previously approved these changes
Nov 18, 2022
Member
Gudahtt
left a comment
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Couple of minor suggestions but this all looks good
Gudahtt
approved these changes
Nov 18, 2022
Gudahtt
added a commit
that referenced
this pull request
Jan 24, 2023
This file has not been used as of the Yarn v3 migration in #119. It was accidentally left behind.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades package manager from Yarn v1 to Yarn v3.
Followed the migration guide + some of the example set in this migration PR for
@metamask/controller