Skip to content

chore: use single header row for post merge spreadsheet#242

Merged
jvbriones merged 3 commits into
mainfrom
chore-post-merge-title
May 4, 2026
Merged

chore: use single header row for post merge spreadsheet#242
jvbriones merged 3 commits into
mainfrom
chore-post-merge-title

Conversation

@jvbriones
Copy link
Copy Markdown
Contributor

@jvbriones jvbriones commented May 1, 2026

The post validation tracker excel template was updated to use a single header row.


Note

Medium Risk
Updates the Google Sheets write/read ranges and row insert/delete indices, which can misalign headers vs appended PR data if the spreadsheet template differs from expectations. Changes are isolated to the post-merge tracking script and don’t affect production runtime code.

Overview
Aligns the post-merge validation tracker spreadsheet format to a single header row by writing all headers (including the platform label) into row 1 and shifting data to start on row 3.

Updates sheet creation from template/blank to insert/delete the correct spacer row, and adjusts readRows/appendRows ranges accordingly so deduping and new PR inserts operate on the new row layout.

Reviewed by Cursor Bugbot for commit 6e2f229. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8657b9b3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 186 to 188
valueInputOption: 'USER_ENTERED',
requestBody: { values: [[platformLabelFor(platformType)]] },
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve headers when creating a non-template sheet

In createSheetFromTemplateOrBlank, the fallback path (when no template tab exists) now only writes A1 and skips writing any column headers. This is a regression from the previous behavior, where A2:H2 was populated via headerRowFor(platformType). If template lookup fails (the exact case this branch handles), the generated tab has unlabeled validation columns, which makes the tracker hard to use and can lead to incorrect manual validation updates.

Useful? React with 👍 / 👎.

Comment thread .github/scripts/post-merge-validation-tracker.mjs
Comment thread .github/scripts/post-merge-validation-tracker.mjs Outdated
racitores
racitores previously approved these changes May 4, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 933fa29. Configure here.

Comment thread .github/scripts/post-merge-validation-tracker.mjs
racitores
racitores previously approved these changes May 4, 2026
@jvbriones jvbriones dismissed stale reviews from racitores and javiergarciavera via 6e2f229 May 4, 2026 08:56
@jvbriones jvbriones merged commit 3c41770 into main May 4, 2026
10 checks passed
@jvbriones jvbriones deleted the chore-post-merge-title branch May 4, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants