feat: add is-snap argument to publish-preview.yml workflow#254
Draft
mikesposito wants to merge 2 commits into
Draft
feat: add is-snap argument to publish-preview.yml workflow#254mikesposito wants to merge 2 commits into
is-snap argument to publish-preview.yml workflow#254mikesposito wants to merge 2 commits into
Conversation
Allow callers to pass arbitrary build-time environment variables to the build step via a JSON object passed as a secret. This is needed by snap consumers whose build commands require additional configuration (e.g. API URLs, RPC endpoints) to produce valid preview builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable publish-preview workflow renames each workspace's package.json#name from
@metamask/...to@metamask-previews/...before running the build. This works for typical libraries but breaks for Snap packages, because:When the rename happens before the build, the bundle and manifest are produced against the preview scope, the shasum is computed over the contaminated bundle, and downstream clients that verify against the published @metamask/... shasum reject the snap.
The workaround used by snap repos today (e.g. snap-tron-wallet) is to build first, then rename — but the reusable workflow had no way to express that ordering.
To fix this issue and make this workflow usable for Snaps, this PR adds a new boolean input
is-snap(default false) to.github/workflows/publish-preview.yml.Existing consumers don't need to change anything. Snap consumers add a single input: