fix: disclose WitnessCreateContract 9,999 TRX burn fee (WPN-1719) - #73
Open
ulissesferreira wants to merge 7 commits into
Open
fix: disclose WitnessCreateContract 9,999 TRX burn fee (WPN-1719)#73ulissesferreira wants to merge 7 commits into
ulissesferreira wants to merge 7 commits into
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Draft
7 tasks
Contributor
Author
|
Draft PR for testing: MetaMask/metamask-extension#45074 |
ulissesferreira
enabled auto-merge
July 31, 2026 09:37
Include getAccountUpgradeCost in fee calculation for WitnessCreateContract so Network fee and insufficient-balance checks reflect the irreversible protocol burn. Replace the generic unsupported-simulation copy with Super Representative candidate disclosure on confirmation. Fixes WPN-1719
cursor
Bot
force-pushed
the
WPN-1719-witness-create-fee
branch
from
July 31, 2026 12:26
7d4d14c to
713a85d
Compare
Replace explicit any types in FeeCalculatorService tests with the Transaction type from tronweb. Revert coverage thresholds to main values since the bumped thresholds are not met. Sync snap.manifest shasum to the value produced by CI production builds. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/tron-wallet-snap.getAccountUpgradeCostin fee calculation forWitnessCreateContractso Network fee and insufficient-balance checks reflect the irreversible 9,999 TRX burn.References
Test plan
yarn workspace @metamask/tron-wallet-snap run testWitnessCreateContractsigning flow shows the 9,999 TRX burn disclosure instead of unsupported-simulation copy