Skip to content

feat: scaffold @metamask/snap-networks-utils (WPN-1632) - #79

Merged
ulissesferreira merged 3 commits into
mainfrom
WPN-1632-scaffold-snap-networks-utils
Jul 31, 2026
Merged

feat: scaffold @metamask/snap-networks-utils (WPN-1632)#79
ulissesferreira merged 3 commits into
mainfrom
WPN-1632-scaffold-snap-networks-utils

Conversation

@ulissesferreira

@ulissesferreira ulissesferreira commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Scaffold empty @metamask/snap-networks-utils via yarn create-package so MONO-2 extraction tickets can land as move+import changes
  • Wire package into root tsconfigs, lockfile, and README; assign Networks CODEOWNERS
  • Align template Jest/TypeScript deps with the monorepo; no snap consumers yet

Test plan

  • yarn workspace @metamask/snap-networks-utils run build
  • yarn workspace @metamask/snap-networks-utils run test
  • yarn constraints
  • Confirm no snap package.json depends on @metamask/snap-networks-utils

Add an empty shared workspace via create-package so MONO-2 extraction
tickets can land as move+import changes. Align template deps with the
monorepo and assign Networks CODEOWNERS.

WPN-1632
@ulissesferreira
ulissesferreira requested review from a team as code owners July 31, 2026 08:21
@socket-security

socket-security Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​typedoc-plugin-missing-exports@​2.3.01001007683100
Addednpm/​@​ts-bridge/​cli@​0.6.4831008081100
Addednpm/​typedoc@​0.25.131001009890100

View full report

@socket-security

socket-security Bot commented Jul 31, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • npm/shiki@0.14.7
  • npm/vscode-oniguruma@1.7.0
  • npm/cjs-module-lexer@1.4.3
  • npm/marked@4.3.0

View full report

Replace the create-package greeter with a minimal shared logger so snaps
can import a real module from the scaffold package.

WPN-1632
@ulissesferreira

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/shiki@0.14.7
Transitive via typedoc (devDependency only, docs/build tooling).
"Obfuscated" alert is minified highlighter + TextMate grammars.
Network/fetch is for loading onig.wasm and local theme/grammar assets.
Same version already ignored in MetaMask/eth-json-rpc-middleware#426; also present in MetaMask/core via typedoc.

@ulissesferreira

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/vscode-oniguruma@1.7.0
Transitive via typedoc → shiki (devDependency only).
fetch is Emscripten WASM bootstrap (same-origin).
Publisher change alexandrudima → vscode-bot is Microsoft maintainers on microsoft/vscode-oniguruma.
Same version ignored in MetaMask/eth-json-rpc-middleware#426; also in MetaMask/core.

@ulissesferreira

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/cjs-module-lexer@1.4.3
Transitive via @ts-bridge/cli (build tooling only; not in published dist).
Official nodejs/cjs-module-lexer; installed sources use JSON.parse, not eval.
Already present in this repo via Jest as a different major.

@ulissesferreira

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/marked@4.3.0
Transitive via typedoc (docs tooling only; not in published dist).
AI alert is about markdown URL sanitization; only used for typedoc HTML docs.
Same typedoc→marked@4.3.0 stack already in MetaMask/core.

@ulissesferreira
ulissesferreira added this pull request to the merge queue Jul 31, 2026
Merged via the queue into main with commit 274237f Jul 31, 2026
87 checks passed
@ulissesferreira
ulissesferreira deleted the WPN-1632-scaffold-snap-networks-utils branch July 31, 2026 14:40
cursor Bot pushed a commit that referenced this pull request Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants