refactor: simplify AssetsService types - #84
Merged
ulissesferreira merged 3 commits intoJul 31, 2026
Conversation
mikesposito
commented
Jul 31, 2026
mikesposito
commented
Jul 31, 2026
Member
Author
There was a problem hiding this comment.
@ulissesferreira given this file is now just a couple of type declarations, we could consider merging it with AssetsService.ts - wdyt?
Contributor
There was a problem hiding this comment.
Yeah that seems fair so we can maintain less files. Sounds good.
3 tasks
mikesposito
commented
Jul 31, 2026
Comment on lines
-10
to
-14
| export type { | ||
| AssetsControllerGetAccountAssetByIDAction, | ||
| AssetsControllerGetAccountAssetsByIDsAction, | ||
| AssetsControllerGetAccountAssetsByScopeAction, | ||
| }; |
Member
Author
There was a problem hiding this comment.
Better not to re-export these types from another package, because any breaking change on these types from @metamask/assets-controller would turn into a breaking change for @metamask/snap-networks-utils as well.
Consumers can simply import them from @metamask/assets-controller instead
ulissesferreira
approved these changes
Jul 31, 2026
ulissesferreira
merged commit Jul 31, 2026
0b342b9
into
WPN-1784-shared-assets-service
31 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Proposal to simplify
AssetsServicetypes and returned values, to align it to what's currently returned by AssetsController's actions.References
Related to #82
Checklist