fix: disable dnode weak on nodejs for node@10 support

.circleci/scripts/deps-install.sh

@@ -17,7 +17,6 @@ yarn --frozen-lockfile --ignore-scripts --har --ignore-engines
 
 # for test
 (cd node_modules/scrypt && yarn run install)
-(cd node_modules/weak && yarn run install)
 (cd node_modules/chromedriver && yarn run install)
 (cd node_modules/geckodriver && yarn run postinstall)
 

app/scripts/metamask-controller.js

@@ -1517,7 +1517,9 @@ export default class MetamaskController extends EventEmitter {
    */
   setupControllerConnection (outStream) {
     const api = this.getApi()
-    const dnode = Dnode(api)
+    // the "weak: false" option is for nodejs only (eg unit tests)
+    // it is a workaround for node v12 support
+    const dnode = Dnode(api, { weak: false })
     // report new active controller connection
     this.activeControllerConnections++
     this.emit('controllerConnectionChanged', this.activeControllerConnections)

app/scripts/phishing-detect.js

@@ -35,11 +35,13 @@ function start () {
 
 function setupControllerConnection (connectionStream, cb) {
   const eventEmitter = new EventEmitter()
+  // the "weak: false" option is for nodejs only (eg unit tests)
+  // it is a workaround for node v12 support
   const metaMaskControllerDnode = dnode({
     sendUpdate (state) {
       eventEmitter.emit('update', state)
     },
-  })
+  }, { weak: false })
   connectionStream.pipe(metaMaskControllerDnode).pipe(connectionStream)
   metaMaskControllerDnode.once('remote', (backgroundConnection) => cb(null, backgroundConnection))
 }

app/scripts/ui.js

@@ -153,11 +153,13 @@ function setupWeb3Connection (connectionStream) {
  */
 function setupControllerConnection (connectionStream, cb) {
   const eventEmitter = new EventEmitter()
+  // the "weak: false" option is for nodejs only (eg unit tests)
+  // it is a workaround for node v12 support
   const backgroundDnode = Dnode({
     sendUpdate: function (state) {
       eventEmitter.emit('update', state)
     },
-  })
+  }, { weak: false })
   connectionStream.pipe(backgroundDnode).pipe(connectionStream)
   backgroundDnode.once('remote', function (backgroundConnection) {
     backgroundConnection.on = eventEmitter.on.bind(eventEmitter)