Skip to content

chore(deps): lockbump @metask/eth-sig-util to 6.0.2 and 7.0.1 - #7902

Closed
legobeat wants to merge 2 commits into
MetaMask:mainfrom
legobeat:deps-lockbump-eth-sig-util
Closed

chore(deps): lockbump @metask/eth-sig-util to 6.0.2 and 7.0.1#7902
legobeat wants to merge 2 commits into
MetaMask:mainfrom
legobeat:deps-lockbump-eth-sig-util

Conversation

@legobeat

@legobeat legobeat commented Nov 22, 2023

Copy link
Copy Markdown
Contributor
  • Bump lockfile resolution of @metamask/eth-sig-util@^6.0.0 to 6.0.2
  • Bump lockfile resolution of @metamask/eth-sig-util@^7.0.0 to 7.0.1

Related npm audit deprecation for 6.0.1 and 7.0.0:

   ├─ Issue: This version generates invalid signatures for messages that include the value "0x" in a "bytes" field. This has been fixed in v6.0.2 and v7.0.1
   ├─ Severity: moderate
   ├─ Vulnerable Versions: 7.0.0
   │
   ├─ Tree Versions
   │  └─ 7.0.0
   │
   └─ Dependents
      └─ @metamask/eth-json-rpc-middleware@npm:12.0.1

Related issues

Manual testing steps

[...]

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added type-bug Something isn't working dependencies Pull requests that update a dependency file team-application-security Application security team labels Nov 22, 2023
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 22, 2023
@legobeat
legobeat marked this pull request as ready for review November 22, 2023 08:04
@legobeat
legobeat requested a review from a team as a code owner November 22, 2023 08:04
@socket-security

Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author @metamask/eth-sig-util 6.0.2
Unstable ownership @metamask/eth-sig-util 6.0.2

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @metamask/eth-sig-util@6.0.2

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (025b627) 37.39% compared to head (a190b39) 37.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7902   +/-   ##
=======================================
  Coverage   37.39%   37.39%           
=======================================
  Files        1052     1052           
  Lines       28173    28173           
  Branches     2517     2517           
=======================================
  Hits        10534    10534           
  Misses      17040    17040           
  Partials      599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElvisKrop

Copy link
Copy Markdown

Hello guys 👋
Please merge this PR asap, we really need this deps update 🙏
Thanks in advance!

@legobeat legobeat removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 29, 2023
@legobeat

Copy link
Copy Markdown
Contributor Author

@legobeat legobeat closed this Nov 29, 2023
@legobeat
legobeat deleted the deps-lockbump-eth-sig-util branch November 29, 2023 23:36
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file team-application-security Application security team type-bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ethers signTypedData returns incorrect signature / recovered address

5 participants