Lint GitHub Actions workflows#125
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Mrtenz
force-pushed
the
mrtenz/lint-github-actions
branch
from
0ac3cae to
70ede45
Compare
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Download actionlint |
There was a problem hiding this comment.
What do you think about including these steps in the job above so that we don't have to check the repo out again?
If we want to keep this separate: I notice you bumped the version of actions/checkout in this job. Do we want to also change the version of actions/checkout above?
There was a problem hiding this comment.
What do you think about including these steps in the job above so that we don't have to check the repo out again?
I think it's a good time to start parallelising different steps, like we're doing in MetaMask/core#941. Will try to use a similar approach for this!
If we want to keep this separate: I notice you bumped the version of actions/checkout in this job. Do we want to also change the version of actions/checkout above?
Probably a good idea, since v2 is deprecated, AFAIK.
There was a problem hiding this comment.
I just realised that we'll need to check out the repo again regardless if we want to parallelise it. Linting the workflows doesn't require a Yarn install either, so there's no need to change it.
Will still bump the actions/checkout version though!
Gudahtt
left a comment
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM!
Did a test run here, and it correctly flagged an invalid property: https://github.com/MetaMask/metamask-module-template/actions/runs/3321724280/jobs/5489762237
3 participants
This adds
actionlintto automatically lint GitHub Actions workflows. This can catch potential errors such as the one caused in #123.