Adds ability to create multiple tokens and watch all of them. - #259
Merged
Conversation
jiexi
reviewed
Oct 5, 2023
adonesky1
reviewed
Oct 6, 2023
adonesky1
left a comment
adonesky1
left a comment
Contributor
There was a problem hiding this comment.
Not sure I follow how this enables us to test multiple different batched token addresses. Could you include a video of the expected UX?
Contributor
Author
|
Currently in the test dapp, when creating a token we create a instance of the ERC20 token and use that address watchAsset, but any subsequent token creation would override the previous one. In this pr when we create a new token we append that address to the test-dapp-pr-259.mov |
jiexi
previously approved these changes
Oct 6, 2023
adonesky1
reviewed
Oct 6, 2023
adonesky1
reviewed
Oct 6, 2023
adonesky1
previously approved these changes
Oct 6, 2023
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
jiexi
approved these changes
Oct 6, 2023
adonesky1
approved these changes
Oct 6, 2023
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to create multiple tokens and watch all of them. Shouldn't effect other token methods, they will use the latest created token address for approval and transfers.
For context: https://github.com/MetaMask/MetaMask-planning/issues/1407