Skip to content

Switch eth-sig-util to @metamask/eth-sig-util - #286

Merged
tmashuang merged 9 commits into
mainfrom
mm-eth-sig-util
Apr 30, 2024
Merged

Switch eth-sig-util to @metamask/eth-sig-util#286
tmashuang merged 9 commits into
mainfrom
mm-eth-sig-util

Conversation

@tmashuang

Copy link
Copy Markdown
Contributor

Switch over the user of eth-sig-util to @metamask/eth-sig-util and update method params.

@socket-security

socket-security Bot commented Jan 24, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/micro-ftch@0.3.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat
legobeat requested review from Gudahtt, rekmarks and seaona and removed request for Gudahtt and seaona April 15, 2024 06:21
Comment thread package.json Outdated
@legobeat

Copy link
Copy Markdown
Contributor
@SocketSecurity ignore npm/micro-ftch@0.3.1

network access ok

@rekmarks rekmarks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tmashuang
tmashuang merged commit 314b221 into main Apr 30, 2024
@tmashuang
tmashuang deleted the mm-eth-sig-util branch April 30, 2024 23:55
@seaona seaona mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants