Custom font with Nametags module#3610
Closed
misten1 wants to merge 3 commits intoMeteorDevelopment:masterfrom
misten1:improvements
Closed
Custom font with Nametags module#3610misten1 wants to merge 3 commits intoMeteorDevelopment:masterfrom misten1:improvements
misten1 wants to merge 3 commits intoMeteorDevelopment:masterfrom
misten1:improvements
Conversation
|
This is probably insert a hook into the C update feeds. I'd say umm...no. |
Collaborator
what? |
Contributor
|
can u do it for EntityOwner too? |
Contributor
Author
|
Probably |
Contributor
Author
I have a implementation but idk if it's worth another pr or smth |
Contributor
also need to release texture of previously initialized textrenderer i think |
Contributor
Author
|
Should be good now |
Contributor
also, if we don't care about the Minecraft font renderer, the "text" field could just be a CustomTextRenderer, so we don't need to cast it to a CustomTextRenderer in that case. |
Contributor
Author
|
Thanks, I've added the null check + removed the unnecessary cast |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Allows users to choose custom font with Nametags module
without changing clickgui font
Related issues
Mention any issues that this pr relates to.
How Has This Been Tested?
Videos or screenshots of the changes if applicable.

Checklist: