Skip to content

Custom font with Nametags module#3610

Closed
misten1 wants to merge 3 commits intoMeteorDevelopment:masterfrom
misten1:improvements
Closed

Custom font with Nametags module#3610
misten1 wants to merge 3 commits intoMeteorDevelopment:masterfrom
misten1:improvements

Conversation

@misten1
Copy link
Copy Markdown
Contributor

@misten1 misten1 commented Apr 30, 2023

Type of change

  • Bug fix
  • New feature

Description

Allows users to choose custom font with Nametags module
without changing clickgui font

Related issues

Mention any issues that this pr relates to.

How Has This Been Tested?

  • Tested on a cpvp server
  • Tested on singleplayer with lots of entites

Videos or screenshots of the changes if applicable.
image

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@BDARmech
Copy link
Copy Markdown

This is probably insert a hook into the C update feeds. I'd say umm...no.

@Wide-Cat
Copy link
Copy Markdown
Collaborator

This is probably insert a hook into the C update feeds. I'd say umm...no.

what?

@WERooo
Copy link
Copy Markdown
Contributor

WERooo commented May 22, 2023

can u do it for EntityOwner too?

@misten1
Copy link
Copy Markdown
Contributor Author

misten1 commented May 22, 2023

Probably

@misten1
Copy link
Copy Markdown
Contributor Author

misten1 commented May 22, 2023

can u do it for EntityOwner too?

I have a implementation but idk if it's worth another pr or smth

@WERooo
Copy link
Copy Markdown
Contributor

WERooo commented May 24, 2023

can u do it for EntityOwner too?

I have a implementation but idk if it's worth another pr or smth

also need to release texture of previously initialized textrenderer i think

@misten1
Copy link
Copy Markdown
Contributor Author

misten1 commented May 24, 2023

Should be good now

@WERooo
Copy link
Copy Markdown
Contributor

WERooo commented May 24, 2023

Should be good now

also, if we don't care about the Minecraft font renderer, the "text" field could just be a CustomTextRenderer, so we don't need to cast it to a CustomTextRenderer in that case.

@misten1
Copy link
Copy Markdown
Contributor Author

misten1 commented May 24, 2023

Thanks, I've added the null check + removed the unnecessary cast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom font option nametags

4 participants