Feat/v1#36
Merged
Merged
Conversation
ossiggy
commented
Jun 3, 2024
ossiggy
commented
Contributor
- Adds all v2 methods, along with tests
- Updates Readme
- Bumps to v1.0.0
V1 updates
…e structure clean up
…irements to include testing modules, added testing utils
|
Hi @ossiggy what's the status of committing this into the repo? There are some things here that we'd like to play around with (eg. CreditScore) that are not available in the released version of the lib. Thanks! |
dwilliams27
approved these changes
Jul 31, 2024
|
|
||
|
|
||
| class PlaidBalance(TypedDict): | ||
| available: Optional[int] |
There was a problem hiding this comment.
Minor, but the spacing seems off on some of the classes in this file
| usage_pattern: Optional[AccountLiabilityCreditCardUsageTypesLiterals] | ||
|
|
||
|
|
||
| class AccountLiabilityCollection(AccountLiabilityBase): |
sbilalh
reviewed
Jul 31, 2024
Member
There was a problem hiding this comment.
could use some linting but otherwise fine
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.