[Low] SDK Sync: Bump version + API version#76
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4bd5f6617
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 'Content-Type': 'application/json', | ||
| 'User-Agent': 'Method-Python/v{version}'.format(version=version('method-python')), | ||
| 'method-version': '2025-07-04' | ||
| 'method-version': '2026-03-30' |
There was a problem hiding this comment.
Keep the old API version until attributes are migrated
With this header every SDK call opts into 2026-03-30, but the attributes resources still expose the older contract: EntityAttributesResource.create() requires a selector body and the response types expect credit_health_* entries with rating, while the 2026-03-30 attributes docs show create() with no body and responses as an async attribute map of {value, error}. Users of method.entities(...).attributes or method.accounts(...).attributes who only upgrade the SDK will silently receive data that no longer matches the SDK surface, so the attributes resources/types need to be migrated in the same change or this header should remain on the previous API version.
Useful? React with 👍 / 👎.
e4bd5f6 to
8ef0c7d
Compare
Codex Review AssessmentComment 1 (P2) - API version bump without updating attributes resources: |
Low priority — bump package version 2.1.1 to 2.2.0, update API version header from 2025-07-04 to 2026-03-30, minor webhook type annotation fix.