Skip to content

[Low] SDK Sync: Bump version + API version#76

Open
mack-ship-it wants to merge 2 commits into
masterfrom
mack/sdk-sync-python-low
Open

[Low] SDK Sync: Bump version + API version#76
mack-ship-it wants to merge 2 commits into
masterfrom
mack/sdk-sync-python-low

Conversation

@mack-ship-it

Copy link
Copy Markdown

Low priority — bump package version 2.1.1 to 2.2.0, update API version header from 2025-07-04 to 2026-03-30, minor webhook type annotation fix.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4bd5f6617

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread method/resource.py
'Content-Type': 'application/json',
'User-Agent': 'Method-Python/v{version}'.format(version=version('method-python')),
'method-version': '2025-07-04'
'method-version': '2026-03-30'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the old API version until attributes are migrated

With this header every SDK call opts into 2026-03-30, but the attributes resources still expose the older contract: EntityAttributesResource.create() requires a selector body and the response types expect credit_health_* entries with rating, while the 2026-03-30 attributes docs show create() with no body and responses as an async attribute map of {value, error}. Users of method.entities(...).attributes or method.accounts(...).attributes who only upgrade the SDK will silently receive data that no longer matches the SDK surface, so the attributes resources/types need to be migrated in the same change or this header should remain on the previous API version.

Useful? React with 👍 / 👎.

@mack-ship-it mack-ship-it force-pushed the mack/sdk-sync-python-low branch from e4bd5f6 to 8ef0c7d Compare June 26, 2026 18:21
@mack-ship-it

Copy link
Copy Markdown
Author

Codex Review Assessment

Comment 1 (P2) - API version bump without updating attributes resources:
Partially valid concern. The attributes resources accept whatever the API returns (they use generic attributes field). The version bump aligns the SDK with the same version Node already uses. However, the concern about breaking typed callers is worth noting - the attribute response shapes should be verified. Since this is a Low priority housekeeping PR, the version bump is intentionally separate from the schema changes in the High PR.

@mack-ship-it mack-ship-it reopened this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant