Skip to content

Move samples repos Readme content into regular Docs - #2069

Merged
Patrick Brosset (captainbrosset) merged 35 commits into
mainfrom
user/v-mhoffman/readmes-content
Sep 16, 2022
Merged

Move samples repos Readme content into regular Docs#2069
Patrick Brosset (captainbrosset) merged 35 commits into
mainfrom
user/v-mhoffman/readmes-content

Conversation

@mikehoffms

@mikehoffms Michael Hoffman (mikehoffms) commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

@mikehoffms Michael Hoffman (mikehoffms) added the cat: webview2 WebView-related content. label Jul 20, 2022
@mikehoffms
Michael Hoffman (mikehoffms) marked this pull request as ready for review July 21, 2022 01:44
@opbld33

This comment was marked as outdated.

@mikehoffms
Michael Hoffman (mikehoffms) marked this pull request as draft July 21, 2022 20:06
@mikehoffms Michael Hoffman (mikehoffms) changed the title Move samples repos Readme content into regular Docs Expand Readme steps to be explicit end-to-end Jul 21, 2022
@mikehoffms Michael Hoffman (mikehoffms) changed the title Expand Readme steps to be explicit end-to-end Move samples repos Readme content into regular Docs Jul 23, 2022
@mikehoffms
Michael Hoffman (mikehoffms) marked this pull request as ready for review July 23, 2022 00:19
@opbld31

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

Comment thread microsoft-edge/webview2/samples/webview2browser.md Outdated
Comment thread microsoft-edge/webview2/how-to/machine-setup.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very clean. I hardly found anything.

@opbld31

This comment was marked as outdated.

@opbld33

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

@mikeshhoffman

Copy link
Copy Markdown
Contributor

Nishitha Burman Dey (@nishitha-burman) - please review and possibly approve this PR. Reezaali Patrick Brosset (@captainbrosset) fyi/test msg

  • mikeshhoffman (pers.)

Comment thread microsoft-edge/webview2/get-started/get-started.md
Comment thread microsoft-edge/webview2/samples/webview2browser.md Outdated
Comment thread microsoft-edge/webview2/samples/webview2apissample.md Outdated
Comment thread microsoft-edge/webview2/samples/webview2apissample.md Outdated
@opbld30

This comment was marked as outdated.

@opbld33

opbld33 commented Sep 15, 2022

Copy link
Copy Markdown

Docs Build status updates of commit c1b2aac:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/media/windows-keyboard-logo.png ✅Succeeded View
microsoft-edge/toc.yml ✅Succeeded View
microsoft-edge/webview2/code-samples-links.md ✅Succeeded View
microsoft-edge/webview2/concepts/basic-authentication.md ✅Succeeded View
microsoft-edge/webview2/concepts/distribution.md ✅Succeeded View
microsoft-edge/webview2/concepts/navigation-events.md ✅Succeeded View
microsoft-edge/webview2/concepts/process-model.md ✅Succeeded View
microsoft-edge/webview2/concepts/threading-model.md ✅Succeeded View
microsoft-edge/webview2/get-started/get-started.md ✅Succeeded View
microsoft-edge/webview2/get-started/media/vs2022-create-a-new-project.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/get-started/media/wpf-getting-started-mng-nuget.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/get-started/winforms.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui2.md ✅Succeeded View
microsoft-edge/webview2/get-started/wpf.md ✅Succeeded View
microsoft-edge/webview2/how-to/chromium-devtools-protocol.md ✅Succeeded View
microsoft-edge/webview2/how-to/hostobject.md ✅Succeeded View
microsoft-edge/webview2/how-to/machine-setup.md ✅Succeeded View
microsoft-edge/webview2/how-to/winrt-from-js.md ✅Succeeded View
microsoft-edge/webview2/index.md ✅Succeeded View
microsoft-edge/webview2/samples/deployment-samples.md ✅Succeeded View
microsoft-edge/webview2/samples/media/unsupported-review-project-dialog.png ✅Succeeded View
microsoft-edge/webview2/samples/media/webview2apisample-app-window.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/samples/media/webview2apisample-in-solution-explorer.png ✅Succeeded n/a (file deleted)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@captainbrosset

Copy link
Copy Markdown
Contributor

As discussed with Michael offline, Nishitha has already approved this somewhere else. So I'll go ahead and merge this.

@captainbrosset
Patrick Brosset (captainbrosset) deleted the user/v-mhoffman/readmes-content branch September 16, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat: webview2 WebView-related content.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants