Skip to content

Clean up of code with pylint.#112

Merged
Miksus merged 1 commit into
Miksus:masterfrom
marksmayo:master
Sep 25, 2022
Merged

Clean up of code with pylint.#112
Miksus merged 1 commit into
Miksus:masterfrom
marksmayo:master

Conversation

@marksmayo
Copy link
Copy Markdown
Contributor

Using pylint, I've fixed all instances of newlines missing, spaces, and imports. All tests pass (1625/1625).

Using pylint, I've fixed all instances of newlines missing, spaces, and imports.  All tests pass (1625/1625)
@Miksus
Copy link
Copy Markdown
Owner

Miksus commented Sep 25, 2022

Thanks! There are quite a lot of cleaning to be done. At some point I think Flake8 or other style validators should be added to the CI and this sort of PRs will lessen the burden a lot.

I don't feel great at the moment so I'll check and merge this PR later.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 95.51% // Head: 95.23% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (0b0765d) compared to base (a8e509b).
Patch coverage: 95.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   95.51%   95.23%   -0.28%     
==========================================
  Files          88       79       -9     
  Lines        4612     4322     -290     
==========================================
- Hits         4405     4116     -289     
+ Misses        207      206       -1     
Impacted Files Coverage Δ
rocketry/_setup.py 100.00% <ø> (ø)
rocketry/conditions/task/utils.py 90.12% <ø> (-0.47%) ⬇️
rocketry/conds/__init__.py 100.00% <ø> (ø)
rocketry/core/time/__init__.py 100.00% <ø> (ø)
rocketry/core/utils/meta.py 100.00% <ø> (ø)
rocketry/exc.py 100.00% <ø> (ø)
rocketry/log/defaults.py 100.00% <ø> (ø)
rocketry/log/handlers.py 100.00% <ø> (ø)
rocketry/parse/time.py 100.00% <ø> (ø)
rocketry/parse/utils/parser.py 100.00% <ø> (ø)
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Miksus
Copy link
Copy Markdown
Owner

Miksus commented Sep 25, 2022

The codecov/project "failed" but I think that's nothing concerning. The failure is due to some unnecessary lines being removed. I cannot see any problems with this: the relevant import paths are the same and all tests pass. Also, the test coverage is still over 95%.

Thanks again for the contribution! This is very helpful.

@Miksus Miksus merged commit f2f556d into Miksus:master Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants