Clean up of code with pylint.#112
Conversation
Using pylint, I've fixed all instances of newlines missing, spaces, and imports. All tests pass (1625/1625)
|
Thanks! There are quite a lot of cleaning to be done. At some point I think Flake8 or other style validators should be added to the CI and this sort of PRs will lessen the burden a lot. I don't feel great at the moment so I'll check and merge this PR later. |
Codecov ReportBase: 95.51% // Head: 95.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 95.51% 95.23% -0.28%
==========================================
Files 88 79 -9
Lines 4612 4322 -290
==========================================
- Hits 4405 4116 -289
+ Misses 207 206 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The codecov/project "failed" but I think that's nothing concerning. The failure is due to some unnecessary lines being removed. I cannot see any problems with this: the relevant import paths are the same and all tests pass. Also, the test coverage is still over 95%. Thanks again for the contribution! This is very helpful. |
Using pylint, I've fixed all instances of newlines missing, spaces, and imports. All tests pass (1625/1625).