add __str__ to TaskRunnable in conds#149
Conversation
|
Link to issue: issue |
|
Thanks for the contribution, I think that looks good. Mind you creating a test case for this? I can also do it in case the test suites seem confusing, probably have time on Saturday for it. Sorry for the delay in response. |
Codecov ReportBase: 94.90% // Head: 95.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 94.90% 95.05% +0.14%
==========================================
Files 80 80
Lines 4454 4467 +13
==========================================
+ Hits 4227 4246 +19
+ Misses 227 221 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Yep, I think so too :) The tests are a bit dependent on how fast your system is. It's pretty hard to do tests that test race conditions without relying on execution times. And that means the tests can depend on how fast your system is. The most important thing is that the tests work well on the CI. But I think it looks good. Thanks for the contribution and the effort you saw to fix this! |


This pull request adds str method to TaskRunnable, found in rocketry.conditions.task.task.TaskRunnable.
By adding str method to TaskRunnable, we solve issue of AttributeError in issue (to be updated: I will create an issue) and let cast TaskRunnable to string.