Skip to content

BUG: Cache before startup#155

Merged
Miksus merged 7 commits into
masterfrom
fix/cache_before_setup
Nov 27, 2022
Merged

BUG: Cache before startup#155
Miksus merged 7 commits into
masterfrom
fix/cache_before_setup

Conversation

@Miksus
Copy link
Copy Markdown
Owner

@Miksus Miksus commented Nov 27, 2022

This PR fixes the issue with incorrect cache if repo is changed with app.startup.

Also, the cache init is now at session start and not at the task init.

@Miksus Miksus added the bug Something isn't working label Nov 27, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 27, 2022

Codecov Report

Base: 95.34% // Head: 95.36% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (75ce6c9) compared to base (c69e7eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   95.34%   95.36%   +0.01%     
==========================================
  Files          80       80              
  Lines        4643     4656      +13     
==========================================
+ Hits         4427     4440      +13     
  Misses        216      216              
Impacted Files Coverage Δ
rocketry/core/schedule.py 93.61% <100.00%> (+0.13%) ⬆️
rocketry/core/task.py 92.24% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Miksus Miksus merged commit 046e601 into master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants