improv. error 500 without id#44
Merged
Merged
Conversation
Eywek
requested changes
Aug 1, 2019
| function ajax_get($id = null) | ||
| { // Permet d'afficher le contenu du modal avant l'achat (ajax) | ||
| $this->response->type('json'); | ||
| $this->autoRender = false; |
Member
There was a problem hiding this comment.
Au lieu de fuckup les tabulations et faire encore plus de if comme ça fais juste:
if (!isset($id)) {
return;
}Par contre je comprends pas trop comment ce bug peut avoir lieu
Member
Author
There was a problem hiding this comment.
Je sais pas c’est google qui m’a averti de cette erreur donc je l’ai patch
Member
There was a problem hiding this comment.
Non mais ok pour le bug, mais au lieu de faire un if gigantesque, tu met juste ca au debut
Member
Author
|
j'avais pas vu ce que tu demandais ;x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.