Update benchmark.py for specifying models to use#5
Open
theodufort wants to merge 1 commit intoMinhNgyuen:masterfrom
Open
Update benchmark.py for specifying models to use#5theodufort wants to merge 1 commit intoMinhNgyuen:masterfrom
theodufort wants to merge 1 commit intoMinhNgyuen:masterfrom
Conversation
Added the --models parameter to allow specific models to be ran, if you dont want to run some models
Omega-Centauri-21
approved these changes
Nov 24, 2024
Omega-Centauri-21
left a comment
There was a problem hiding this comment.
- Improvement: This change provides more flexibility by allowing users to specify which models to benchmark.
- Code Quality: The changes are well-structured and maintain the readability of the script.
- Impact: It simplifies the process of benchmarking specific models and ensures users are informed if they specify non-existent models.
Overall, the changes are beneficial and should be approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the --models parameter to allow specific models to be ran, if you dont want to run some models