GEOPY-875: Add warning message if version differ#607
Merged
Conversation
domfournier
requested review from
benk-mira and
sebhmg
and removed request for
sebhmg
sebhmg
reviewed
Sep 1, 2023
sebhmg
reviewed
Sep 1, 2023
Contributor
There was a problem hiding this comment.
is it realistic to ensure backward compatibility and warn only if geoapps package is older than version in the file?
In addition, it can still warn for older versions in file where backward compatibility was lost (that is versions that are known to be incompatible with current geoapps version).
sebhmg
reviewed
Sep 1, 2023
sebhmg
requested changes
Sep 1, 2023
sebhmg
requested changes
Sep 1, 2023
Contributor
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
thanks ! see suggestions in test
sebhmg
requested changes
Sep 5, 2023
Contributor
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
in test, ensure that no warning is emitted
Co-authored-by: Sébastien Hensgen <sebastienh@mirageoscience.com>
sebhmg
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-875 - Add geoapps version to ui.json file.