Skip to content

GEOPY-378#627

Merged
domfournier merged 19 commits into
developfrom
GEOPY-378
Nov 7, 2023
Merged

GEOPY-378#627
domfournier merged 19 commits into
developfrom
GEOPY-378

Conversation

@jamiefb
Copy link
Copy Markdown
Contributor

@jamiefb jamiefb commented Nov 1, 2023

GEOPY-378 - Allow the ocTree mesh created with geoapps to be compatable with UBC

andrewg-mira and others added 15 commits October 31, 2023 15:05
updates:
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)
- [github.com/asottile/pyupgrade: v3.10.1 → v3.13.0](asottile/pyupgrade@v3.10.1...v3.13.0)
- [github.com/rstcheck/rstcheck: v6.1.2 → v6.2.0](rstcheck/rstcheck@v6.1.2...v6.2.0)
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@jamiefb jamiefb changed the base branch from develop to GEOPY-1188 November 1, 2023 21:07
Copy link
Copy Markdown
Contributor

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. See small comments.

Comment thread geoapps/octree_creation/constants.py Outdated
Comment thread geoapps/octree_creation/driver.py Outdated
Comment thread geoapps/octree_creation/driver.py Outdated
Comment thread geoapps/octree_creation/driver.py Outdated
Comment thread geoapps/octree_creation/driver.py Outdated
Comment thread geoapps/utils/testing.py
Comment thread tests/run_tests/octree_creation_test.py Outdated
@domfournier domfournier self-requested a review November 2, 2023 20:06
domfournier
domfournier previously approved these changes Nov 2, 2023
Copy link
Copy Markdown
Contributor

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Moving to test

Base automatically changed from GEOPY-1188 to develop November 2, 2023 20:20
@domfournier domfournier dismissed their stale review November 2, 2023 20:20

The base branch was changed.

@domfournier domfournier self-requested a review November 7, 2023 16:27
@domfournier domfournier merged commit 3846da3 into develop Nov 7, 2023
@domfournier domfournier deleted the GEOPY-378 branch November 7, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants