Skip to content

GEOPY-2862: Inversion crash on tile mesh creation transferring data #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 3 commits into from
May 12, 2026
Merged

GEOPY-2862: Inversion crash on tile mesh creation transferring data #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac45200
Augment unit test
domfournier May 12, 2026
aa58e1c
Fix logic
domfournier May 12, 2026
52ef883
Merge branch 'release/GA_4.8' into GEOPY-2862
domfournier May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simpeg_drivers/components/meshes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def ensure_cell_convention(mesh: Octree) -> TreeMesh | None:
indices = treemesh.get_containing_cells(mesh.centroids)
ind = np.argsort(indices)
for child in mesh.children:
if child.values is None or isinstance(child.values, np.ndarray):
if child.values is None or not isinstance(child.values, np.ndarray):
continue
child.values = child.values[ind]

Expand Down
1 change: 1 addition & 0 deletions tests/driver_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,5 @@ def test_mesh_visual_parameters_copy(tmp_path: Path):
gz_uncertainty=2e-3,
)
driver = GravityInversionDriver(params)
assert driver.inversion_mesh.ensure_cell_convention(mesh) is not None
Comment thread
domfournier marked this conversation as resolved.
assert driver.inversion_mesh.entity.visual_parameters.colour == [255, 0, 0]
Loading