Skip to content

GEOPY-2686: Improve topography augmentation for DC and MT#408

Open
domfournier wants to merge 5 commits into
release/GA_4.8from
GEOPY-2686
Open

GEOPY-2686: Improve topography augmentation for DC and MT#408
domfournier wants to merge 5 commits into
release/GA_4.8from
GEOPY-2686

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented May 15, 2026

GEOPY-2686 - Improve topography augmentation for DC and MT

Copilot AI review requested due to automatic review settings May 15, 2026 21:40
@github-actions github-actions Bot changed the title GEOPY-2686 GEOPY-2686: Improve topography augmentation for DC and MT May 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates active-cell expansion behavior for surface-constrained inversions and refreshes expected run-test targets affected by the numerical change.

Changes:

  • Includes current electrodes when locating containing cells for 2D tensor meshes.
  • Reworks forced-to-surface active-cell expansion using a KD-tree proximity search.
  • Updates expected inversion metrics in DC/IP/MT and joint cross-gradient run tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
simpeg_drivers/utils/utils.py Uses both potential and current electrode locations for tensor mesh containing-cell lookup.
simpeg_drivers/components/topography.py Changes topography active-cell reference and neighbor expansion logic.
tests/run_tests/driver_dc_test.py Updates 3D DC target metrics.
tests/run_tests/driver_dc_2d_test.py Updates 2D DC target metrics.
tests/run_tests/driver_ip_test.py Updates 3D IP target metrics.
tests/run_tests/driver_ip_2d_test.py Updates 2D IP target metrics.
tests/run_tests/driver_mt_test.py Updates MT target metrics.
tests/run_tests/driver_joint_cross_gradient_test.py Updates expected misfit scaling and multipliers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg_drivers/components/topography.py
Comment thread simpeg_drivers/components/topography.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (23097b7) to head (c70ac17).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/GA_4.8     #408      +/-   ##
==================================================
- Coverage           90.42%   90.31%   -0.12%     
==================================================
  Files                 110      110              
  Lines                6527     6525       -2     
  Branches              826      824       -2     
==================================================
- Hits                 5902     5893       -9     
- Misses                413      421       +8     
+ Partials              212      211       -1     
Files with missing lines Coverage Δ
simpeg_drivers/components/topography.py 96.49% <100.00%> (+2.94%) ⬆️
simpeg_drivers/utils/utils.py 65.15% <100.00%> (-2.13%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants