GEOPY-2686: Improve topography augmentation for DC and MT#408
Open
domfournier wants to merge 5 commits into
Open
GEOPY-2686: Improve topography augmentation for DC and MT#408domfournier wants to merge 5 commits into
domfournier wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates active-cell expansion behavior for surface-constrained inversions and refreshes expected run-test targets affected by the numerical change.
Changes:
- Includes current electrodes when locating containing cells for 2D tensor meshes.
- Reworks forced-to-surface active-cell expansion using a KD-tree proximity search.
- Updates expected inversion metrics in DC/IP/MT and joint cross-gradient run tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
simpeg_drivers/utils/utils.py |
Uses both potential and current electrode locations for tensor mesh containing-cell lookup. |
simpeg_drivers/components/topography.py |
Changes topography active-cell reference and neighbor expansion logic. |
tests/run_tests/driver_dc_test.py |
Updates 3D DC target metrics. |
tests/run_tests/driver_dc_2d_test.py |
Updates 2D DC target metrics. |
tests/run_tests/driver_ip_test.py |
Updates 3D IP target metrics. |
tests/run_tests/driver_ip_2d_test.py |
Updates 2D IP target metrics. |
tests/run_tests/driver_mt_test.py |
Updates MT target metrics. |
tests/run_tests/driver_joint_cross_gradient_test.py |
Updates expected misfit scaling and multipliers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #408 +/- ##
==================================================
- Coverage 90.42% 90.31% -0.12%
==================================================
Files 110 110
Lines 6527 6525 -2
Branches 826 824 -2
==================================================
- Hits 5902 5893 -9
- Misses 413 421 +8
+ Partials 212 211 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2686 - Improve topography augmentation for DC and MT