GEOPY-1220#37
Merged
Merged
Conversation
benk-mira
approved these changes
Nov 30, 2023
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Some loose suggestions about variable naming, docstrings and typing.
| if f is None: | ||
| f, Ainv = self.fields(self.model, return_Ainv=True) | ||
| @delayed | ||
| def block_deriv(time_index, field_type, source_list, mesh, time_mesh, fields, Jmatrix): |
There was a problem hiding this comment.
since I've seen other simpeg updates replacing camel case for snake case..
Jmatrix -> sensitivity_matrix
rx -> receiver
df_duT -> derivative_... ?
PTv -> Projection?
Also.. not sure how strict you want to be about docstrings/typing on SimPeg, but this is pretty thin by our standards!
Author
There was a problem hiding this comment.
Yea not typing yet on SimPEG. I sprinkle whenever I have the chance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.