Skip to content

GEOPY-2195: Broadcasting of update fails on multiple workers #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 1 commit into from
May 16, 2025
Merged

GEOPY-2195: Broadcasting of update fails on multiple workers #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions simpeg/dask/objective_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,15 @@ def _validate_type_or_future_of_type(
property_name, objects, obj_type, ensure_unique=True
)
workload = [[]]
lookup = {}
count = 0
for obj in objects:
if count == len(workers):
count = 0
workload.append([])
obj.simulation.simulations[0].worker = workers[count]
future = client.scatter([obj], workers=workers[count])[0]

lookup[obj] = (future, workers[count])
if hasattr(obj, "name"):
future.name = obj.name

Expand All @@ -100,7 +101,7 @@ def _validate_type_or_future_of_type(
raise TypeError(f"{property_name} futures must be an instance of {obj_type}")

if return_workers:
return workload, workers
return workload, workers, lookup
else:
return workload

Expand Down Expand Up @@ -390,7 +391,7 @@ def objfcts(self):
def objfcts(self, objfcts):
client = self.client

futures, workers = _validate_type_or_future_of_type(
futures, workers, lookup = _validate_type_or_future_of_type(
"objfcts",
objfcts,
L2DataMisfit,
Expand All @@ -404,8 +405,8 @@ def objfcts(self, objfcts):
self._workers = workers

self._lookup = {
obj.simulation: (future, worker)
for future, worker, obj in zip(futures[0], workers, objfcts)
misfit.simulation: (future, worker)
for misfit, (future, worker) in lookup.items()
}

def residuals(self, m, f=None):
Expand Down Expand Up @@ -443,12 +444,12 @@ def broadcast_updates(self, updates: dict):
if fun not in self._lookup:
continue

objfct, worker = self._lookup[fun]
future, worker = self._lookup[fun]

stores.append(
client.submit(
_setter_broadcast,
objfct,
future,
key,
value,
workers=worker,
Expand Down