Replace image describing post-build script#7
Merged
BalestraPatrick merged 4 commits intoMobileNativeFoundation:masterfrom Jun 15, 2019
codedbypm:master
Merged
Replace image describing post-build script#7BalestraPatrick merged 4 commits intoMobileNativeFoundation:masterfrom codedbypm:master
BalestraPatrick merged 4 commits intoMobileNativeFoundation:masterfrom
codedbypm:master
Conversation
Collaborator
|
Hey! Do you mind taking the screenshot with the light mode and resize the window to be smaller in such a way that the important code in the script is bigger? I'll be happy to merge the PR after that 😄 |
Contributor
Author
Done |
Collaborator
|
We actually removed |
Contributor
Author
|
I think consistency is key in documentation. IMO then also the code block above the image should be updated. What do you think? |
Collaborator
|
Yes, you're right. Let's also change that one! |
BalestraPatrick
approved these changes
Jun 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the wrong image in the README.md regarding XCode integration.