Expand $TEST_UNDECLARED_OUTPUTS_DIR when running test from bazel#553
Merged
Conversation
Signed-off-by: Nan Wang <nanwang1101@yahoo.com>
nanwng
force-pushed
the
nanwng/expand_test_undeclared_outputs_dir
branch
from
dc05d21 to
9a907b2
Compare
ob
reviewed
May 16, 2023
ob
approved these changes
May 18, 2023
nanwng
added a commit
that referenced
this pull request
May 24, 2023
nanwng
added a commit
that referenced
this pull request
May 24, 2023
Signed-off-by: Nan Wang <nanwang1101@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when running bluepill from bazel,
$TEST_UNDECLARED_OUTPUTS_DIRis not accessible from test runtime by passing with--test_envSupporting it by expanding the variable in the shell script and passing it to the test plan.
So we can run something like
bazel test Taget --config Debug --test_env SCREENSHOT_DIR=\$TEST_UNDECLARED_OUTPUTS_DIR/screenshots. Then the screenshot can be saved to the undeclared outputs dir and be packaged to the finalbazel-testlogfolderref: https://bazel.build/reference/test-encyclopedia#initial-conditions