feat(bindings): tnumber numeric functions (arithmetic + unary + distance)#43
Closed
estebanzimanyi wants to merge 1 commit into
Closed
feat(bindings): tnumber numeric functions (arithmetic + unary + distance)#43estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
Combines the tnumber numeric surface:
- Arithmetic operators: +, -, *, / for {tint, tfloat} × {scalar, tnumber}
(24 registrations) using TemporalBinaryV<T> dispatch
- Unary functions: abs, derivative, degrees, radians (12 registrations)
using TemporalUnary
- Distance: <-> for tnumber × tnumber and nad / nearestApproachDistance
named functions
Each function family routes through one of the existing templated
helpers so each ScalarFunction body is a single-line lambda calling
the corresponding MEOS *_tnumber_tnumber / arithop_tnumber_number
entrypoint.
estebanzimanyi
changed the base branch from
feat/tbool-tor-tand-ttext-text
to
main
estebanzimanyi
force-pushed
the
feat/tnumber-numeric-functions
branch
from
672f31b to
02fe2f2
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines the tnumber numeric surface into a single PR (~262 lines):
+,-,*,/for{tint, tfloat} × {scalar, tnumber}abs,derivative,degrees,radians<->for tnumber × tnumber,nad,nearestApproachDistanceEach family routes through one of the existing templated helpers (
TemporalBinaryV<T>,TemporalUnary,TempTempBoolPred-style) so eachScalarFunctionbody is a single-line lambda calling the corresponding MEOS entrypoint.This PR consolidates three previously stacked PRs that all targeted the tnumber numeric surface and shared the same dispatch helpers — splitting them by op family added review burden without independent decision points.
Test plan
Replaces