feat(bindings): tile emitters — bins/valueBins/timeBins/valueBoxes/valueTimeBoxes#82
Closed
estebanzimanyi wants to merge 1 commit into
Closed
feat(bindings): tile emitters — bins/valueBins/timeBins/valueBoxes/valueTimeBoxes#82estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
…lueTimeBoxes
Closes the LIST-emitting tail of temporal/025_temporal_tile.
New scalar tile emitters (28 SQL registrations):
- bins(span, size[, origin]) -> LIST(span)
6 overloads across {intspan, floatspan, tstzspan} × 2 origin variants.
- valueBins(tnumber, vsize[, vorigin]) -> LIST(span)
4 overloads (tint × 2 + tfloat × 2).
- timeBins(temporal, duration[, torigin]) -> LIST(tstzspan)
8 overloads (4 base types × 2 origin variants).
- valueBoxes(tnumber, vsize[, vorigin]) -> LIST(tbox)
4 overloads.
- valueTimeBoxes(tnumber, vsize, duration[, vorigin[, torigin]]) -> LIST(tbox)
6 overloads.
Each routes to the matching MEOS export (intspan_bins / floatspan_bins /
tstzspan_bins / tint_value_bins / tfloat_value_bins / temporal_time_bins /
tint_value_boxes / tfloat_value_boxes / tint_value_time_boxes /
tfloat_value_time_boxes). The shared EmitFlatList<T> helper writes a
flat LIST(span/tbox) by allocating a child vector of fixed-size blobs
and pointing the row's list_entry_t to its slice — same pattern as
PR #79's tile emitters and PR #72's tboxes/splitN/splitEachN.
Hooked into LoadInternal via a new RegisterTileEmitters method on
TemporalTypes.
Test: test/sql/parity/025_tile_emitters.test (11 assertions covering
each emitter on each base type, default-origin and explicit-origin
variants, and the value-time cross-product).
Full suite: 763 / 14 cases under TZ=UTC.
Files also gain a trailing newline at EOF.
Member
Author
|
Superseded by the consolidated PR branch |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the LIST-emitting tail of `temporal/025_temporal_tile`. Companion to PR #81's TableFunction split surface.
New SQL surface (28 scalar registrations)
Implementation
A shared `EmitFlatList` helper writes a flat `LIST(span/tbox)` by allocating a child vector of fixed-size blobs and pointing the row's `list_entry_t` to its slice — same pattern as PR #79's tile emitters and PR #72's `tboxes`/`splitN`/`splitEachN`.
Hooked into `LoadInternal` via a new `RegisterTileEmitters` method on `TemporalTypes`, kept distinct from the scalar registrations and the `tempUnnest` / tile-split TableFunctions.
Tests
Coverage delta
Per the audit in PR #66 and combined with PR #81 (TableFunction splits):
Test plan