th3index family on the canonical UDF surface#24
Closed
estebanzimanyi wants to merge 2 commits into
Closed
Conversation
This was referenced Jun 12, 2026
The MobilitySpark base UDF library — temporal, geo, boxes, time and set surfaces plus the base infrastructure — bound to the canonical single-source functions.GeneratedFunctions surface (the MEOS-API / meos-idl.json codegen output), bundled as libs/JMEOS-1.4.jar regenerated against the ecosystem pin, with lib/libmeos.so built from the pin (CBUFFER/NPOINT/POSE/RGEO + H3). Every UDF binds the generated surface directly; the legacy hand-rolled functions.functions facade is retired. The pg_-prefixed PG-compat I/O (pg_interval_in/out, pg_timestamptz_in) is preserved to disambiguate the PostgreSQL built-ins of the same name. CI builds libmeos from the ecosystem pin on Linux/macOS (with H3, and an in-source build dir so pgtypes/postgres.h's relative ../../meos/include resolves); Windows is non-blocking. Full unit suite green (907/907). The th3index, sibling (cbuffer/npoint/pose/rgeo) and portable-operator families stack on this foundation as separate changes; the BerlinMOD benchmark builds on the full surface.
The temporal H3-index (th3index) family for MobilitySpark, stacked on the foundation library: the h3index/th3index UDFs (Th3IndexUDFs), the H3 cell prefilter (Th3IndexPrefilterUDFs) and the JNR bindings, registered in the session. th3index is backed by libmeos built with -DH3=ON (the standalone library wires the h3 object library at the current ecosystem pin); the UDFs bind the generated functions.GeneratedFunctions surface (th3index_*, h3index_in/out, the canonicalized parse/to_string -> in/out). No change to the library surface, so the unit suite is unchanged (907/907).
estebanzimanyi
force-pushed
the
feat/family-th3index
branch
from
5e84926 to
c386544
Compare
estebanzimanyi
added a commit
to estebanzimanyi/MobilitySpark
that referenced
this pull request
Jun 14, 2026
GeneratedSurfaceTest registers the catalog-generated UDFs (GeneratedSpatioTemporalUDFs.registerAll) in a real SparkSession and asserts results across families via spark.sql against libmeos: temporal_num_instants==3, tint_start_value==1, tint_out renders the values, tnumber_integral is finite — the safety gate proving the generated surface binds and executes before the hand UDF layers (MobilityDB#22/MobilityDB#24/MobilityDB#25/MobilityDB#26) are retired. Adds junit-jupiter + surefire (fork per class, JDK17 --add-opens) and bumps jnr-ffi to 2.2.17. NOTE: these Spark-integration tests require JDK 17 — Spark 3.4 cannot init on JDK 21 (DirectByteBuffer.<init>(long,int) removed) and the Java-17 JMEOS jar cannot load on JDK 11. CI must run the Spark build/test on JDK 17.
estebanzimanyi
added a commit
to estebanzimanyi/MobilitySpark
that referenced
this pull request
Jun 14, 2026
GeneratedSurfaceTest registers the catalog-generated UDFs (GeneratedSpatioTemporalUDFs.registerAll) in a real SparkSession and asserts results across families via spark.sql against libmeos: temporal_num_instants==3, tint_start_value==1, tint_out renders the values, tnumber_integral is finite — the safety gate proving the generated surface binds and executes before the hand UDF layers (MobilityDB#22/MobilityDB#24/MobilityDB#25/MobilityDB#26) are retired. Adds junit-jupiter + surefire (fork per class, JDK17 --add-opens) and bumps jnr-ffi to 2.2.17. NOTE: these Spark-integration tests require JDK 17 — Spark 3.4 cannot init on JDK 21 (DirectByteBuffer.<init>(long,int) removed) and the Java-17 JMEOS jar cannot load on JDK 11. CI must run the Spark build/test on JDK 17.
Member
Author
|
Superseded by the catalog-driven generator (#27 foundation + #28 generated dispatch) and the rebuilt benchmark (#23), which now consumes the catalog-GENERATED UDF surface end-to-end. Per the North Star (bindings generated from the MEOS-API catalog, zero hand-written UDF surface), this hand UDF layer is retired; #23 no longer stacks on it, so there is no remaining consumer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #22 (the foundation library). Adds the temporal H3-index (th3index) family —
Th3IndexUDFs(h3index/th3index UDFs),Th3IndexPrefilterUDFs(H3 cell prefilter), and the JNR bindings — registered in the session.Backed by libmeos built with
-DH3=ON(the standalone library wires the h3 object library at the current pin); binds the generatedfunctions.GeneratedFunctionssurface (th3index_*,h3index_in/out, the canonicalizedparse/to_string→in/out). No library-surface change — unit suite unchanged (907/907). Review #22 first; this PR's own change is the th3index commit on top.