Update module structure#1
Merged
Merged
Conversation
Remove pre-built pymeos_cffi/__init__.py and functions.py from git. Update build process to generate these files on installation. Remove builder module from wheels.
…ion is dynamic in pyproject.toml)
Add tests for sdist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the structure of
pymeos_cffito two different modules:pymeos_cffiandbuilder.The
builderpackage, previously located inpymeos_cffi/buildercontains the code that generates thefunctions.pyand__init__.py. This structure makes the separation of purpose clearer, and also allows for a easier packaging, since source distributions have to contain both modules, but build distributions don't require debuildermodule.This PR also:
pymeostests from build workflow, and replaces them with a quickpymeos_cfficheck, since it's not really logical to test a package that depends onpymeos_cffiwhen preparing a new version.macos-14for python versions 3.8 and 3.9, that were disabled due to an issue with the GitHub Runners.pycachefrom distributions