Skip to content

chore: Upgrade to Java 11 - #1014

Merged
aababilov merged 4 commits into
MobilityData:masterfrom
aababilov:java-11
Sep 23, 2021
Merged

chore: Upgrade to Java 11#1014
aababilov merged 4 commits into
MobilityData:masterfrom
aababilov:java-11

Conversation

@aababilov

@aababilov aababilov commented Sep 22, 2021

Copy link
Copy Markdown
Collaborator

Google has finally upgraded to Java 11, so the open-source validator
does not have to use the old Java 8 (see pull #595 and pull #759).

Java memory is reduced from 12 to 8 GiB to make the tests pass.

@aababilov

Copy link
Copy Markdown
Collaborator Author

End-to-end 100 test failed on Ruler, Norway

9s
0s
Run java -Xmx12G -Xms12G -jar main/build/libs/*.jar --url http://transitfeeds.com/p/ruter/240/latest/download --output_base output --country_code no --storage_directory ruter.zip
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000500000000, 12884901888, 0) failed; error='Not enough space' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 12884901888 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /home/runner/work/gtfs-validator/gtfs-validator/hs_err_pid1746.log

Google has finally upgraded to Java 11, so the open-source validator
does not have to use the old Java 8 (see pull MobilityData#595).
Try to avoid insufficient memory errors.
@aababilov

Copy link
Copy Markdown
Collaborator Author

Reducing memory from 12 to 8 GiB made a miracle - now the tests pass!

Comment thread .github/workflows/docker.yml
@botanize

Copy link
Copy Markdown

Should this PR also update the java version requirement in README.md?

@aababilov

Copy link
Copy Markdown
Collaborator Author

Should this PR also update the java version requirement in README.md?

Done.

@aababilov
aababilov requested a review from barbeau September 23, 2021 21:56

@barbeau barbeau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aababilov

Copy link
Copy Markdown
Collaborator Author

Thank you!

@aababilov
aababilov merged commit 092f608 into MobilityData:master Sep 23, 2021
@isabelle-dr isabelle-dr mentioned this pull request Oct 28, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants