feat: Too fast trip travel speed - #710
Merged
Merged
Conversation
added 6 commits
February 1, 2021 10:12
- implement new validation rule - implement GeoUtil class - draft unit tests - create new notice - update RULES.md
- write new logic rule - additional unit tests - update RULES.md
# Conflicts: # RULES.md
lionel-nj
marked this pull request as draft
February 3, 2021 19:26
# Conflicts: # RULES.md
Contributor
Author
|
This PR relies on a dependency that is not supported by Google, as a result, the implementation of this new rule is postponed until @aababilov evaluates possibilities #708 (comment) |
* Only process each trip once * Refactor forEach to simple loop to clarify behavior * Refactor distance variables and method to use double instead of float and int * Refactor utility method signature to remove need for trip object * Cleanup docs - remove references to "error" * Add docs for method of distance calculation * Fix existing tests
# Conflicts: # RULES.md # main/src/main/java/org/mobilitydata/gtfsvalidator/util/GeospatialUtil.java # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopTooFarFromTripShapeValidator.java # main/src/test/java/org/mobilitydata/gtfsvalidator/util/GeospatialUtilTest.java # main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopTooFarFromTripShapeValidatorTest.java
…/gtfs-validator into fix-stop-too-far-from-shape
- draft one more unit test to verify the number of method invocations - make checkStopsWithinTripShape package private
- draft one more unit test to verify the number of method invocations - make checkStopsWithinTripShape package private
Mockito captures parameters by reference and not value, so we get the final state of the cache, not the state after each method invocation
stop_times.txt should only have stops location_types 0 and 4, so validation for that can be done elsewhere.
stop_times.txt should only have stops location_types 0 and 4, so validation for that can be done elsewhere.
This also has the effect of using Euclidean instead of Geodetic buffers, which saves execution time and likely memory, and doesn't seem to result in a level of error that causes problems. So the tradeoff of performance vs. accuracy seems acceptable. See #750 (comment) for details.
added 3 commits
February 22, 2021 12:15
…o too-fast-travel
- split validator method - add javadocs
lionel-nj
marked this pull request as ready for review
February 22, 2021 19:00
barbeau
suggested changes
Feb 22, 2021
barbeau
left a comment
barbeau
left a comment
Member
There was a problem hiding this comment.
Thanks @lionel-nj! Some comments in-line.
barbeau
reviewed
Feb 23, 2021
added 4 commits
February 23, 2021 10:53
# Conflicts: # main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopTooFarFromTripShapeValidator.java # main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopTooFarFromTripShapeValidatorTest.java
added 3 commits
February 24, 2021 11:34
- check algorithm on non-timepoints stop times - check algorithm on StopTimeWithArrivalBeforePreviousDepartureTimeNotice case
- handle non-timepoints stop times - handle StopTimeWithArrivalBeforePreviousDepartureTimeNotice situation - rework checkSpeedAlongTrip to take tripId and tripStopTimes as a list - as two parameters - update javadocs
barbeau
suggested changes
Feb 24, 2021
barbeau
left a comment
barbeau
left a comment
Member
There was a problem hiding this comment.
Thanks @lionel-nj, looks pretty good! A few more items in-line.
- refactor for consistency - beginStopSequence: rework rule logic to no longer maintain a list on integer - rework tests for clarity - additional unit test - improve documentation TODO: finish test refactor + additional unit test for non time points fast and non fast travel
Contributor
Author
|
@barbeau reading #765 (comment): it seems like I implemented the solution 2 you suggested.
|
Contributor
Author
Done. I also reworked the tests to ease clarity and reading. @barbeau |
barbeau
approved these changes
Feb 25, 2021
| @Test | ||
| public void fastTravelFarStopsShouldGenerateNotice() { | ||
| // sample table descriptions available at: | ||
| // https://gist.github.com/lionel-nj/d21cc8b1519d4f44f9ebd53858cda78d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #517
Please review after #708
Summary:
This PR implements a new validation rule: check trip travel is reasonable.
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)