fix: Use String.trim instead of String.strip - #758
Merged
Conversation
String.strip is available only from Java 11 while String.trim is more portable. The difference is tiny and we can neglect it in our context: * trim() removes all characters that are less than or equal to 'U+0020' (the space character) * strip() uses Character.isWhitespace function, so it removes fewer characters
Collaborator
Author
|
@barbeau Do you find acceptable if we make our upstream compatible with older Java 8? |
Member
That's fine by me to revert back to |
Collaborator
Author
|
#759 to downgrade the rest of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.strip is available only from Java 11 while String.trim is more
portable.
The difference is tiny and we can neglect it in our context:
(the space character)
characters