fix: Remove Set.of() - #767
Merged
Merged
Conversation
It's only available on Java 9, and we're using Java 8 now
lionel-nj
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The PRs for the switch to Java 8 (#759) and the changes to the rule for StopTooFarFromTripShape (#750) were open simultanouesly, so some Java 9 features snuck in as part of the changes to that rule.
Here's the build that failed on CI:
https://github.com/MobilityData/gtfs-validator/runs/1962540197
This PR removes the Java 9 feature (
Set.of()) that caused the failure.Expected behavior:
Only Java 8 compatible language features should be used.
gradle testto make sure you didn't break anything