Skip to content

feat: Create Python script to track usage of best practices in Mobility Database feeds #72 - #275

Merged
qcdyx merged 5 commits into
mainfrom
feat/72
Sep 26, 2023
Merged

feat: Create Python script to track usage of best practices in Mobility Database feeds #72#275
qcdyx merged 5 commits into
mainfrom
feat/72

Conversation

@cka-y

@cka-y cka-y commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

This script runs a report to assess

Closes #72

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cka-y cka-y changed the title feat: create Python script to track usage of best practices in Mobility Database feeds #72 feat: Create Python script to track usage of best practices in Mobility Database feeds #72 Jun 13, 2023

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! You're awesome.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of titles with semantic prefixes:
- fix: Fix wrong countries for some sources
- feat: Add Features and Status to MDB Schema [SOURCES]
- docs: Improvements to README.md and CONTRIBUTING.md

If your pull request includes adding or updating a source, make sure to end your pull request title with "[SOURCES]" so the GitHub workflow runs.

@@ -0,0 +1,121 @@
from zipfile import ZipFile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Please add a documentation header to Python scripts with a brief usage description and parameters if applicable.

@qcdyx qcdyx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qcdyx
qcdyx merged commit 07b58e2 into main Sep 26, 2023
@qcdyx
qcdyx deleted the feat/72 branch September 26, 2023 12:23
@github-actions

Copy link
Copy Markdown
Contributor

Congrats on getting your first pull request merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants