manifest.json: strip: [] leads to app not starting (ESP32 only)

[lll000111]

Context: https://github.com/Moddable-OpenSource/moddable/blob/public/documentation/tools/manifest.md#strip

Related (but different): #141

Because of #141 I had been using strip: *[]*. Since the updates to the public repo, which I downloaded, this leads to the app not starting. Only on ESP32 (tested: Linux and ESP32).

What happens is that the app is uploaded to the board, I get the message

Hard resetting via RTS pin...

and then xsbug should show something. Instead, no matter how long I wait, nothing happens. No errors, an empty xsbug (no tab for the new machine shows up), nothing.

I could reliably reproduce this, the only thing did was changing back and forth between strip: "*" and strip: "[]". It worked (i.e. didn't work) with several examples such as "files" or "helloworld".

The changes I made from the downloaded repo:

• build/devices/esp32/xsProj/sdkconfig.defaults now sets CONFIG_SPIRAM_SUPPORT=y, plus my USB port is CONFIG_SPIRAM_SUPPORT=y but that was already the case before the moddable repo updates.
• examples/manifest_base.json has the change to "strip"

[lll000111]

Okay, I was being stupid. Of course this needs [] and not "[]". An error message during parsing would have been nice :-) It's a little confusing that the property takes a string or an array (I'm glad I found a reason why this is not my fault though).

[lll000111]

Did I just get confused because it worked on Linux?

Reopening issue — on ESP32, to be sure I repeated a few times after deleting previous build files from build/tmp/, and using "helloworld" as the most simple example (tried others too), even without the quotes, the problem described above occurs when "strip": [], is set.

My repo changes:

$ git status
On branch public
Your branch is up to date with 'origin/public'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   build/devices/esp32/xsProj/partitions.csv
	modified:   build/devices/esp32/xsProj/sdkconfig.defaults
	modified:   examples/manifest_base.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	build/devices/esp32/xsProj/sdkconfig
	build/devices/esp32/xsProj/sdkconfig.defaults.prior
	build/devices/esp32/xsProj/sdkconfig.old

no changes added to commit (use "git add" and/or "git commit -a")
$ git diff examples/manifest_base.json
diff --git a/examples/manifest_base.json b/examples/manifest_base.json
index ec434b62..cefce8e8 100644
--- a/examples/manifest_base.json
+++ b/examples/manifest_base.json
@@ -37,7 +37,7 @@
                "Resource",
                "instrumentation",
        ],
-       "strip": "*",
+       "strip": [],
        "platforms": {
                "esp": {
                        "include": "$(BUILD)/devices/esp/manifest.json"

[lll000111]

Retested after the latest patches, seems to work now.