Skip to content

[WIP] Adding I2C timeout#271

Closed
k45514n wants to merge 1 commit intoModdable-OpenSource:publicfrom
k45514n:I2C-timeout
Closed

[WIP] Adding I2C timeout#271
k45514n wants to merge 1 commit intoModdable-OpenSource:publicfrom
k45514n:I2C-timeout

Conversation

@k45514n
Copy link
Contributor

@k45514n k45514n commented Sep 28, 2019

I'm a little stuck here, but this is as far as I've gotten.

@andycarle
Copy link
Member

Hi Kas,

This is definitely headed in the right direction. Including this configuration option in the constructor's options object seems correct to me.

The rest of the work to be done is basically chasing the change through the I2C implementations on each of the platforms. If it's okay with you, I can take what you've started here and then drop in the platform-specific bits.

To do that, we'll need a completed CLA from you — you could post that here or email it to us.

Cheers!
 - Andy

@k45514n
Copy link
Contributor Author

k45514n commented Oct 9, 2019

Where do I email it to? It has my mailing address so I'd rather not post it here heh.

@andycarle
Copy link
Member

info@moddable.com would be just fine. Thanks!

@k45514n
Copy link
Contributor Author

k45514n commented Oct 25, 2019

So sorry for delays (getting married, etc.) sending now.

@k45514n
Copy link
Contributor Author

k45514n commented Jan 31, 2020

I sent the form in October, is there anything else blocking this? If you give me a lead of where to start in the C I can move this forward if you like.

@andycarle
Copy link
Member

@nodebotanist Thank you for the reminder--let me take a look at this over the weekend and see if we can wrap it up.

@andycarle
Copy link
Member

@nodebotanist I've incorporated the above commit into our tree and built on it to implement i2c timeout configuration on ESP8266 and ESP32. You'll see that update + a basic driver and example app for the Qwiic Twist in our next open source push.

@andycarle
Copy link
Member

@nodebotanist These changes are now live in the open source repo. The new Qwiic Twist driver is here and the example is here. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants