fix(security): harden secrets handling and remove insecure configs#4
Merged
Merged
Conversation
- Redact API key from request logs (api-client.ts) - Redact API key from sync error logs (sync-panel.ts) - Mask API key in settings UI to show only last 4 chars - Clear API key input field value to prevent pre-fill - Remove --allow-running-insecure-content and --disable-web-security CEF flags from manifest.xml - Remove HTTP domain from manifest.json network whitelist - Remove internal test domain (modelslab-studio.test) from manifest - Update default API URL to production (https://mstudio.ai/api/v1) - Regenerate bundled-assets.ts with all fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Hardening — Audit Fixes
Secrets audit found no hardcoded credentials but identified 4 security issues. This PR fixes all of them.
Changes
[key=REDACTED]REDACTED--disable-web-security,--allow-running-insecure-content)••••••••abcd)http://modelslab-studio.testHTTP domain whitelistedhttps://mstudio.ai/api/v1Files Changed
src/core/api-client.ts— redact key from logssrc/ui/panels/sync-panel.ts— redact key from error logsrc/ui/panels/settings-panel.ts— mask key display, clear prefillsrc/core/config.ts— update default API URL to productionCSXS/manifest.xml— remove insecure CEF flagsmanifest.json— remove HTTP/test domains from whitelistscripts/bundled-assets.ts— regenerated with all fixesVerification
npm run typecheck— passes cleannpm run build— passes cleanmodelslab-studio.test--disable-web-security