Skip to content

Fix all the things #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Moderocky merged 2 commits into from
Jun 19, 2022
Merged

Fix all the things #9

Moderocky merged 2 commits into from
Jun 19, 2022

Conversation

@bluelhf
Copy link
Collaborator

@bluelhf bluelhf commented Jun 18, 2022 •
edited
Loading

This pull request fixes several issues related to unimplemented or incorrect code:

  • It makes providing a return type for syntax elements mandatory
  • It adds return type definitions to existing syntax, and fixes incorrect ones
  • It temporarily removes requiresMainThread, which is currently not implemented
  • It allows ExprFunctionExternal to retain type information from pre-compile time to better differentiate between methods of the same name with different parameter types

@bluelhf bluelhf changed the title Add/fix several return types Fix ExprFunctionExternal type specification Jun 18, 2022
@bluelhf bluelhf changed the title Fix ExprFunctionExternal type specification FIx all the things Jun 18, 2022
@bluelhf bluelhf changed the title FIx all the things Fix all the things Jun 18, 2022
@bluelhf
Copy link
Collaborator Author

bluelhf commented Jun 19, 2022

apology

@Moderocky Moderocky merged commit 03851a2 into Moderocky:master Jun 19, 2022
@bluelhf bluelhf mentioned this pull request Jun 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluelhf @Moderocky