Potential Vulnerability in Cloned Code#191
Merged
MrR0b0X merged 1 commit intoMolotovCherry:masterfrom Dec 19, 2025
Merged
Conversation
When doc is NULL, namespace created in xmlTreeEnsureXMLDecl is bind to newDoc->oldNs, in this case, set newDoc->oldNs to NULL and free newDoc will cause a memory leak.
Author
|
Hi @MrR0b0X, thanks for merging our PR. We plan to request a CVE for this issue. Just wanna make sure if you are OK with us proceeding with the CVE submission. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential security vulnerability in xmlParseBalancedChunkMemoryRecover() that was cloned from https://gitlab.gnome.org/GNOME/libxml2 but did not receive the security patch.
Details:
Affected Function: xmlParseBalancedChunkMemoryRecover() in libxml2-2.9.9/parser.c
Original Fix: https://gitlab.gnome.org/GNOME/libxml2/-/commit/5a02583c7e683896d84878bd90641d8d9b0d0549
What this PR does:
This PR applies the same security patch that was applied to the original repository to eliminate the potential vulnerability in the cloned code.
References:
Please review and merge this PR to ensure your repository is protected against this potential vulnerability.