Proof of Concept for Zama Functionality#63
Merged
Merged
Conversation
Comment on lines
+56
to
+57
| let genotype_encrypted = FheUint8::try_encrypt(encoded_genotype, client_key) | ||
| .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))?; // Convert tfhe::Error to std::io::Error |
Contributor
There was a problem hiding this comment.
Why not encrypt the rsid? Can't claim fully encrypted without it.
Contributor
|
Also trying out in general is compressed keys/secrets: https://docs.zama.ai/tfhe-rs/fundamentals/compress |
…ama-poc # Conflicts: # zama-poc/src/main.rs
bhaskarkishore
left a comment
bhaskarkishore
left a comment
Contributor
There was a problem hiding this comment.
The code so far is good. The use of the client key in server side code needs to be revisited, e.g: L90. Ideally if we can refactor its usage out, it will lead of simpler key management.
4 tasks
bhaskarkishore
approved these changes
Sep 12, 2024
bhaskarkishore
left a comment
bhaskarkishore
left a comment
Contributor
There was a problem hiding this comment.
Looks okay for PoC code
vishakh
marked this pull request as ready for review
September 12, 2024 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR builds a PoC for evaluating the suitability of Zama for Monadic DNA.
Done so far:
🧬 Load a 23andMe dataset
🔢 Integer-encode the SNPs and genotypes in the dataset
㊙️ Encrypt genotypes as Zama secrets
🔍 Run lookups for various medical conditions for bechmarking
⏺️ Persist encrypted data to disk and read it back for benchmarking
☎️ Refactor into client / server model to understand client-side encryption and general latency
Left for a future PR:
🔑 Figure out the best way to make key management and usage work