Merged
Conversation
added 7 commits
April 14, 2023 22:12
Copied over refresher on parallelism section and tried to organised content in a logical manner.
Added subheadings to create visual gaps between sub topics
Expanded on the slides content by including advantages to contrast with the disadvantages. Outlined the differences to shared memory architecture whenever possible to help reinforce the previous chapter's content
My understanding is OpenMPI section explains what it is and message passing is actually using openMPI. Let me know if this is correct or if i have it backwards.
Message passing section goes into detail how to use OpenMPI and gives some examples on this. Like the last commit lmk if i need to swap this section and with OpenMPI
Moved tasks from slides into here. Let me know if i need to make any changes to these to make them more relevant
Outline for chapter 5 including the new parallel refresher which is missing from the summary.
4 tasks
added 2 commits
April 15, 2023 10:45
For the book to work properly i needed to update summary.md so that the new topics showed up on the outline. Included few small fixes as well. This commit should be apart of the first pr.
Swapped openMPI section with message Passing as it should come first according to my understanding. This is again done in the summar.md file so you can navigate through the book in the right order.
oraqlle
requested changes
Apr 15, 2023
Contributor
oraqlle
left a comment
oraqlle
left a comment
There was a problem hiding this comment.
Looks good. Some small quality and consistency changes are needed. Try and come up with new challenges and remember to use the challenge repo to add blueprint/template files and lay out the instructions as this will be where they will save there work. With regards to the Message Passing, try and discuss it from a high level first (which you started on in the 'distrub. comp.' section and then go into what OpenMPI is and how to use it.
| ``` C | ||
| int MPI_Init(int * argc, char ** argv); | ||
| // initializes the MPI environment. | ||
| //Argc argv are the parameters come |
Contributor
There was a problem hiding this comment.
Just make sure the C code style is consistent.
Author
There was a problem hiding this comment.
Can I get you to elaborate on what you mean by this?
| @@ -1 +1,50 @@ | |||
| # Challenges | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Try and come up with new challenges. The old repo is not going to be used anymore so they're are not relevant.
improved stuff based on comments on pr for better quality and consistency. Have not updated challenges yet however.
oraqlle
added
the
Distributed Computing Chapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distributed section complete. Added a parallel refresher to recap parallel computing section before diving into distributed computing as per the slides.
#7